Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQL-18468 fix wrong gracejoin answer with spilling on q12 tpc-h #4830

Merged
merged 6 commits into from
May 27, 2024
Merged

YQL-18468 fix wrong gracejoin answer with spilling on q12 tpc-h #4830

merged 6 commits into from
May 27, 2024

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented May 24, 2024 •
edited
Loading

Changelog entry

This PR fixes empty result of q12 tpc-h request coused by spilling of grace-join.
...

Changelog category

  • Bugfix

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner May 24, 2024 11:53
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:55:43 UTC Pre-commit check for 82225ad has started.
⚫ 2024-05-24 11:58:05 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:56:42 UTC Pre-commit check for 82225ad has started.
⚫ 2024-05-24 11:58:05 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:59:37 UTC Pre-commit check for b3903c4 has started.
⚪ 2024-05-24 12:02:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 12:04:48 UTC Build successful.
⚪ 2024-05-24 12:05:01 UTC Tests are running...
🔴 2024-05-24 12:40:00 UTC Test run completed, no test results found for commit d009fb0. Please check build logs.
⚫ 2024-05-24 12:40:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 12:06:05 UTC Pre-commit check for b3903c4 has started.
⚪ 2024-05-24 12:08:36 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 12:11:48 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 12:16:29 UTC Pre-commit check for b3903c4 has started.
⚪ 2024-05-24 12:19:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 12:22:21 UTC Build successful.
⚪ 2024-05-24 12:22:32 UTC Tests are running...
🔴 2024-05-24 12:40:04 UTC Test run completed, no test results found for commit d009fb0. Please check build logs.
⚫ 2024-05-24 12:40:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:50:48 UTC Pre-commit check for 245e821 has started.
⚪ 2024-05-24 13:53:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 13:56:17 UTC Build successful.
⚪ 2024-05-24 13:56:28 UTC Tests are running...
🔴 2024-05-24 15:52:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73534 60820 0 5 12703 6

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:52:09 UTC Pre-commit check for 245e821 has started.
⚪ 2024-05-24 13:54:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 13:59:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:52:30 UTC Pre-commit check for 245e821 has started.
⚪ 2024-05-24 13:55:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 13:57:35 UTC Build successful.
⚪ 2024-05-24 13:57:44 UTC Tests are running...
🔴 2024-05-24 15:55:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14447 14314 0 41 72 20

@lll-phill-lll lll-phill-lll requested review from Darych and yumkam May 24, 2024 18:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 18:42:22 UTC Pre-commit check for d4fadd8 has started.
⚪ 2024-05-24 18:44:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 19:01:09 UTC Build successful.

@lll-phill-lll lll-phill-lll changed the title YQL-18468 fix wrong gracejoin answer with spilling on q12 tpch YQL-18468 fix wrong gracejoin answer with spilling on q12 tpc-h May 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 21:28:23 UTC Pre-commit check for d4fadd8 has started.
⚪ 2024-05-24 21:30:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 21:32:12 UTC Build successful.
⚪ 2024-05-24 21:32:30 UTC Tests are running...
🟢 2024-05-24 23:29:53 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70868 58162 0 0 12700 6

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 21:28:32 UTC Pre-commit check for d4fadd8 has started.
⚪ 2024-05-24 21:31:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 21:32:17 UTC Build successful.
⚪ 2024-05-24 21:32:29 UTC Tests are running...
🔴 2024-05-24 23:39:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11795 11675 0 55 53 12

@lll-phill-lll lll-phill-lll merged commit 59846a7 into ydb-platform:main May 27, 2024
12 of 14 checks passed
@niksaveliev niksaveliev mentioned this pull request May 27, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

@yumkam yumkam Awaiting requested review from yumkam

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lll-phill-lll @Darych